Change in flashrom[master]: bitbang_spi: Add half-duplex optimizations

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/26947 )

Change subject: bitbang_spi: Add half-duplex optimizations
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/26947/2/bitbang_spi.c
File bitbang_spi.c:

https://review.coreboot.org/#/c/26947/2/bitbang_spi.c@128
PS2, Line 128: 		if (i == 0)
             : 			bitbang_spi_set_sck_set_mosi(master, 0, 0);
             : 		else
             : 			bitbang_spi_set_sck(master, 0);
  SPI is an ad-hoc standard; very little is defined
anywhere! […]
I wasn't paying attention obviously. It's not about SPI but
whatever
the flash chip expects after the command. I can see from random data-
sheets that they don't care. But that's no proof that there is no
chip that does care so let's keep it.



-- 
To view, visit https://review.coreboot.org/26947
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33b9f363716f651146c09113bda5fffe53b16738
Gerrit-Change-Number: 26947
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Thompson <daniel.thompson(a)linaro.org>
Gerrit-Reviewer: Daniel Thompson <daniel.thompson(a)linaro.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 26 Jun 2018 18:19:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No