Change in flashrom[master]: Add support to get layout from fmap (e.g. coreboot rom)
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23203 ) Change subject: Add support to get layout from fmap (e.g. coreboot rom) ...................................................................... Patch Set 10: (2 comments) https://review.coreboot.org/#/c/23203/10/cli_classic.c File cli_classic.c: https://review.coreboot.org/#/c/23203/10/cli_classic.c@254 PS10, Line 254: fprintf(stderr, "Error: --fmap and --ifd both specified. Aborting.\n")
If you want to have these two optione really exclusive you shuld check in the case OPTION_IFD if fma […] Layouts shouldn't be exclusive IMO, but we should handle it gracefully (checking conflicts for instance).
https://review.coreboot.org/#/c/23203/10/flashrom.8.tmpl File flashrom.8.tmpl: https://review.coreboot.org/#/c/23203/10/flashrom.8.tmpl@204 PS10, Line 204:
Maybe add "on" here? ok
-- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 10 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh@siemens.com> Gerrit-Comment-Date: Wed, 11 Jul 2018 14:10:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
participants (1)
-
Arthur Heymans (Code Review)