Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59072 )
Change subject: [RFC][WPTST] dummyflasher: support emulation of SR2 ......................................................................
Patch Set 10:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/59072/comment/a0deed55_d3e11612 PS10, Line 11: You've probably tested this patch, probably by running dummyflasher with some programmer params. It would be great to add this info into a commit message.
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/59072/comment/cfcbe318_025668d1 PS10, Line 47: uint8_t emu_status_len; /* number of emulated status bytes */ Is this a number of emulated status bytes in SR2?
https://review.coreboot.org/c/flashrom/+/59072/comment/d74b80c2_ab9d30aa PS10, Line 342: /* XXX: Else reset SR2 parts to zero? */ What does it mean? Is it a TODO?
https://review.coreboot.org/c/flashrom/+/59072/comment/b14ba74c_e312078c PS10, Line 930: data->emu_status_len = 1; Maybe I missed something, but is this value always initialised to 1?
File flashrom.8.tmpl:
https://review.coreboot.org/c/flashrom/+/59072/comment/cb05a268_cd367d21 PS10, Line 781: is an 8-bit or 16-bit hexadecimal value. What does this value mean? I know it was like this before ;) But since you are changing/upgrading this programmer param, you probably know what it is and can add some explanation here. Ideally also examples of 8-bit and 16-bit spi_status values.
-
Anastasia Klimchuk (Code Review)