[XS] Change in flashrom[main]: ichspi: Probe opcode in POSSIBLE_OPCODES[] as well

[Bill XIE (Code Review)]

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Peter Marheine.

Hello Anastasia Klimchuk, Nikolai Artemiev, Peter Marheine, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/flashrom/+/84253?usp=email

to look at the new patch set (#5).

The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)


Change subject: ichspi: Probe opcode in POSSIBLE_OPCODES[] as well
......................................................................

ichspi: Probe opcode in POSSIBLE_OPCODES[] as well

ich_spi_send_command() and ich_spi_send_multicommand() will overwrite
the "Sector erase" opcode with the opcode for command via
reprogram_opcode_on_the_fly(), but not restore it, causing the "Sector
erase" opcode may get lost after sending commands, leaving only "Bulk
erase" opcode which erase the whole chip available.

In the mean time, ich_spi_probe_opcode() used not to report opcodes in
POSSIBLE_OPCODES[] but not in curopcodes->opcode[] as supported.

Now, if the opcode being probed is not in curopcodes->opcode[] but in
POSSIBLE_OPCODES[], it will be reported as supported, and programmed
later by ich_spi_send_(multi)command().

Fix:https://ticket.coreboot.org/issues/556

Change-Id: I3fc831fc072e2af9265835cb2f71bf8c222c6a64
Signed-off-by: persmule <[e-mail]>
---
M ichspi.c
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/84253/5
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/84253?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I3fc831fc072e2af9265835cb2f71bf8c222c6a64
Gerrit-Change-Number: 84253
Gerrit-PatchSet: 5
Gerrit-Owner: Bill XIE <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Nikolai Artemiev <[e-mail]>
Gerrit-Reviewer: Peter Marheine <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Anastasia Klimchuk <[e-mail]>
Gerrit-Attention: Nikolai Artemiev <[e-mail]>
Gerrit-Attention: Peter Marheine <[e-mail]>