Change in flashrom[master]: chipset_enable: Add support for Cannon Lake U Premium

List overview All Threads
Download

newer

older

Change in flashrom[master]:...

Matt DeVillier (Code Review)

5 Jul 2019 5 Jul '19

12:58 a.m.

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/34076 )

Change subject: chipset_enable: Add support for Cannon Lake U Premium ......................................................................

chipset_enable: Add support for Cannon Lake U Premium

Add support for Cannon Lake U Premium (CFL-U/WHL-U). Same as discrete 300-series CNP PCH.

Tested on out-of-tree WHL-U board.

Change-Id: I8a318d63cf408a3b2cec436a3fa6e26cf8552ead Signed-off-by: Matt DeVillier matt.devillier@puri.sm --- M chipset_enable.c 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/76/34076/1

diff --git a/chipset_enable.c b/chipset_enable.c index 3773158..e880e73 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1995,6 +1995,7 @@ {0x8086, 0x9d53, B_S, NT, "Intel", "Kaby Lake U Base", enable_flash_pch100}, {0x8086, 0x9d56, B_S, NT, "Intel", "Kaby Lake Y Premium", enable_flash_pch100}, {0x8086, 0x9d58, B_S, NT, "Intel", "Kaby Lake U Premium", enable_flash_pch100}, + {0x8086, 0x9d84, B_S, NT, "Intel", "Cannon Lake U Premium", enable_flash_pch300}, {0x8086, 0xa141, B_S, NT, "Intel", "Sunrise Point Desktop Sample", enable_flash_pch100}, {0x8086, 0xa142, B_S, NT, "Intel", "Sunrise Point Unknown Sample", enable_flash_pch100}, {0x8086, 0xa143, B_S, NT, "Intel", "H110", enable_flash_pch100},

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Nico Huber (Code Review)

5 Jul 5 Jul

9:53 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34076 )

Change subject: chipset_enable: Add support for Cannon Lake U Premium ......................................................................

Patch Set 1: Code-Review+2

(2 comments)

https://review.coreboot.org/c/flashrom/+/34076/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/flashrom/+/34076/1//COMMIT_MSG@12 PS1, Line 12: Tested on out-of-tree WHL-U board. Reads a little odd, I assume you mean the coreboot tree?

https://review.coreboot.org/c/flashrom/+/34076/1/chipset_enable.c File chipset_enable.c:

https://review.coreboot.org/c/flashrom/+/34076/1/chipset_enable.c@1998 PS1, Line 1998: NT Could mark it DEP right away.

-- To view, visit https://review.coreboot.org/c/flashrom/+/34076 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8a318d63cf408a3b2cec436a3fa6e26cf8552ead Gerrit-Change-Number: 34076 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 05 Jul 2019 07:53:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Matt DeVillier (Code Review)

4:19 p.m.

Hello build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/34076

to look at the new patch set (#2).

Change subject: chipset_enable: Add support for Cannon Lake U Premium ......................................................................

chipset_enable: Add support for Cannon Lake U Premium

Add support for Cannon Lake U Premium (CFL-U/WHL-U). Same as discrete 300-series CNP PCH.

Tested on a WHL-U laptop w/unlocked IFD.

Change-Id: I8a318d63cf408a3b2cec436a3fa6e26cf8552ead Signed-off-by: Matt DeVillier matt.devillier@puri.sm --- M chipset_enable.c 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/76/34076/2

-- To view, visit https://review.coreboot.org/c/flashrom/+/34076 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8a318d63cf408a3b2cec436a3fa6e26cf8552ead Gerrit-Change-Number: 34076 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Matt DeVillier (Code Review)

4:20 p.m.

Hello build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/34076

to look at the new patch set (#3).

Change subject: chipset_enable: Add support for Cannon Lake U Premium ......................................................................

chipset_enable: Add support for Cannon Lake U Premium

Add support for Cannon Lake U Premium (CFL-U/WHL-U). Same as discrete 300-series CNP PCH.

Tested on out-of-tree WHL-U board.

Change-Id: I8a318d63cf408a3b2cec436a3fa6e26cf8552ead Signed-off-by: Matt DeVillier matt.devillier@puri.sm --- M chipset_enable.c 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/76/34076/3

-- To view, visit https://review.coreboot.org/c/flashrom/+/34076 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8a318d63cf408a3b2cec436a3fa6e26cf8552ead Gerrit-Change-Number: 34076 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Matt DeVillier (Code Review)

4:21 p.m.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34076 )

Change subject: chipset_enable: Add support for Cannon Lake U Premium ......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/flashrom/+/34076/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/flashrom/+/34076/1//COMMIT_MSG@12 PS1, Line 12: Tested on out-of-tree WHL-U board.

...

Reads a little odd, I assume you mean the coreboot tree?

Done

https://review.coreboot.org/c/flashrom/+/34076/1/chipset_enable.c File chipset_enable.c:

https://review.coreboot.org/c/flashrom/+/34076/1/chipset_enable.c@1998 PS1, Line 1998: NT

...

Could mark it DEP right away.

Done

-- To view, visit https://review.coreboot.org/c/flashrom/+/34076 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8a318d63cf408a3b2cec436a3fa6e26cf8552ead Gerrit-Change-Number: 34076 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 05 Jul 2019 14:21:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Matt DeVillier (Code Review)

4:24 p.m.

Hello build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/34076

to look at the new patch set (#4).

Change subject: chipset_enable: Add support for Cannon Lake U Premium ......................................................................

chipset_enable: Add support for Cannon Lake U Premium

Add support for Cannon Lake U Premium (CFL-U/WHL-U). Same as discrete 300-series CNP PCH.

Tested on a WHL-U laptop w/unlocked IFD.

Change-Id: I8a318d63cf408a3b2cec436a3fa6e26cf8552ead Signed-off-by: Matt DeVillier matt.devillier@puri.sm --- M chipset_enable.c 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/76/34076/4

-- To view, visit https://review.coreboot.org/c/flashrom/+/34076 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8a318d63cf408a3b2cec436a3fa6e26cf8552ead Gerrit-Change-Number: 34076 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

4:31 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34076 )

Change subject: chipset_enable: Add support for Cannon Lake U Premium ......................................................................

Patch Set 4: Verified+1 Code-Review+2

-- To view, visit https://review.coreboot.org/c/flashrom/+/34076 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8a318d63cf408a3b2cec436a3fa6e26cf8552ead Gerrit-Change-Number: 34076 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 05 Jul 2019 14:31:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

8 Aug 8 Aug

11:29 p.m.

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/34076 )

Change subject: chipset_enable: Add support for Cannon Lake U Premium ......................................................................

chipset_enable: Add support for Cannon Lake U Premium

Add support for Cannon Lake U Premium (CFL-U/WHL-U). Same as discrete 300-series CNP PCH.

Tested on a WHL-U laptop w/unlocked IFD.

Change-Id: I8a318d63cf408a3b2cec436a3fa6e26cf8552ead Signed-off-by: Matt DeVillier matt.devillier@puri.sm Reviewed-on: https://review.coreboot.org/c/flashrom/+/34076 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M chipset_enable.c 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved

diff --git a/chipset_enable.c b/chipset_enable.c index 427182c..1636f7c 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1995,6 +1995,7 @@ {0x8086, 0x9d53, B_S, NT, "Intel", "Kaby Lake U Base", enable_flash_pch100}, {0x8086, 0x9d56, B_S, NT, "Intel", "Kaby Lake Y Premium", enable_flash_pch100}, {0x8086, 0x9d58, B_S, NT, "Intel", "Kaby Lake U Premium", enable_flash_pch100}, + {0x8086, 0x9d84, B_S, DEP, "Intel", "Cannon Lake U Premium", enable_flash_pch300}, {0x8086, 0xa141, B_S, NT, "Intel", "Sunrise Point Desktop Sample", enable_flash_pch100}, {0x8086, 0xa142, B_S, NT, "Intel", "Sunrise Point Unknown Sample", enable_flash_pch100}, {0x8086, 0xa143, B_S, NT, "Intel", "H110", enable_flash_pch100},

-- To view, visit https://review.coreboot.org/c/flashrom/+/34076 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8a318d63cf408a3b2cec436a3fa6e26cf8552ead Gerrit-Change-Number: 34076 Gerrit-PatchSet: 6 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1717

days inactive

1752

days old

flashrom-gerrit@flashrom.org

7 comments

2 participants

tags (0)

participants (2)

Matt DeVillier (Code Review)
Nico Huber (Code Review)