Change in flashrom[master]: raiden_debug_spi: add missing USB_SPI requests
Mary Ruthven has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/43525 ) Change subject: raiden_debug_spi: add missing USB_SPI requests ...................................................................... raiden_debug_spi: add missing USB_SPI requests Add the missing USB_SPI requests from platform/cr50 BUG=none BRANCH=none TEST=none Signed-off-by: Mary Ruthven <mruthven@chromium.org> Change-Id: I49c0c28566ed36af6fa03e23a878d19462c55f70 --- M raiden_debug_spi.c 1 file changed, 11 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/43525/1 diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c index ac74c0b..b55307a 100644 --- a/raiden_debug_spi.c +++ b/raiden_debug_spi.c @@ -136,10 +136,17 @@ }; enum raiden_debug_spi_request { - RAIDEN_DEBUG_SPI_REQ_ENABLE = 0x0000, - RAIDEN_DEBUG_SPI_REQ_DISABLE = 0x0001, - RAIDEN_DEBUG_SPI_REQ_ENABLE_AP = 0x0002, - RAIDEN_DEBUG_SPI_REQ_ENABLE_EC = 0x0003, + RAIDEN_DEBUG_SPI_REQ_ENABLE = 0x0000, + RAIDEN_DEBUG_SPI_REQ_DISABLE = 0x0001, + RAIDEN_DEBUG_SPI_REQ_ENABLE_AP = 0x0002, + RAIDEN_DEBUG_SPI_REQ_ENABLE_EC = 0x0003, + RAIDEN_DEBUG_SPI_REQ_ENABLE_H1 = 0x0004, + RAIDEN_DEBUG_SPI_REQ_RESET = 0x0005, + RAIDEN_DEBUG_SPI_REQ_BOOT_CFG = 0x0006, + RAIDEN_DEBUG_SPI_REQ_SOCKET = 0x0007, + RAIDEN_DEBUG_SPI_REQ_SIGNING_START = 0x0008, + RAIDEN_DEBUG_SPI_REQ_SIGNING_SIGN = 0x0009, + }; #define PACKET_HEADER_SIZE (2) -- To view, visit https://review.coreboot.org/c/flashrom/+/43525 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I49c0c28566ed36af6fa03e23a878d19462c55f70 Gerrit-Change-Number: 43525 Gerrit-PatchSet: 1 Gerrit-Owner: Mary Ruthven <mruthven@chromium.org> Gerrit-MessageType: newchange
Brian Nemec has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43525 ) Change subject: raiden_debug_spi: add missing USB_SPI requests ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/43525 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I49c0c28566ed36af6fa03e23a878d19462c55f70 Gerrit-Change-Number: 43525 Gerrit-PatchSet: 1 Gerrit-Owner: Mary Ruthven <mruthven@chromium.org> Gerrit-Reviewer: Brian Nemec <bnemec@chromium.org> Gerrit-Reviewer: Brian Nemec <bnemec@google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Vadim Bendebury <vbendeb@chromium.org> Gerrit-Comment-Date: Thu, 16 Jul 2020 22:09:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43525 ) Change subject: raiden_debug_spi: add missing USB_SPI requests ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/43525 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I49c0c28566ed36af6fa03e23a878d19462c55f70 Gerrit-Change-Number: 43525 Gerrit-PatchSet: 1 Gerrit-Owner: Mary Ruthven <mruthven@chromium.org> Gerrit-Reviewer: Brian Nemec <bnemec@chromium.org> Gerrit-Reviewer: Brian Nemec <bnemec@google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Vadim Bendebury <vbendeb@chromium.org> Gerrit-Comment-Date: Thu, 16 Jul 2020 22:12:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/43525 ) Change subject: raiden_debug_spi: add missing USB_SPI requests ...................................................................... raiden_debug_spi: add missing USB_SPI requests Add the missing USB_SPI requests from platform/cr50 BUG=none BRANCH=none TEST=none Signed-off-by: Mary Ruthven <mruthven@chromium.org> Change-Id: I49c0c28566ed36af6fa03e23a878d19462c55f70 Reviewed-on: https://review.coreboot.org/c/flashrom/+/43525 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Brian Nemec <bnemec@google.com> Reviewed-by: Edward O'Callaghan <quasisec@chromium.org> --- M raiden_debug_spi.c 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved Brian Nemec: Looks good to me, but someone else must approve diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c index b8e19fe..f167a3a 100644 --- a/raiden_debug_spi.c +++ b/raiden_debug_spi.c @@ -399,10 +399,17 @@ }; enum raiden_debug_spi_request { - RAIDEN_DEBUG_SPI_REQ_ENABLE = 0x0000, - RAIDEN_DEBUG_SPI_REQ_DISABLE = 0x0001, - RAIDEN_DEBUG_SPI_REQ_ENABLE_AP = 0x0002, - RAIDEN_DEBUG_SPI_REQ_ENABLE_EC = 0x0003, + RAIDEN_DEBUG_SPI_REQ_ENABLE = 0x0000, + RAIDEN_DEBUG_SPI_REQ_DISABLE = 0x0001, + RAIDEN_DEBUG_SPI_REQ_ENABLE_AP = 0x0002, + RAIDEN_DEBUG_SPI_REQ_ENABLE_EC = 0x0003, + RAIDEN_DEBUG_SPI_REQ_ENABLE_H1 = 0x0004, + RAIDEN_DEBUG_SPI_REQ_RESET = 0x0005, + RAIDEN_DEBUG_SPI_REQ_BOOT_CFG = 0x0006, + RAIDEN_DEBUG_SPI_REQ_SOCKET = 0x0007, + RAIDEN_DEBUG_SPI_REQ_SIGNING_START = 0x0008, + RAIDEN_DEBUG_SPI_REQ_SIGNING_SIGN = 0x0009, + }; /* -- To view, visit https://review.coreboot.org/c/flashrom/+/43525 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I49c0c28566ed36af6fa03e23a878d19462c55f70 Gerrit-Change-Number: 43525 Gerrit-PatchSet: 4 Gerrit-Owner: Mary Ruthven <mruthven@chromium.org> Gerrit-Reviewer: Brian Nemec <bnemec@chromium.org> Gerrit-Reviewer: Brian Nemec <bnemec@google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Vadim Bendebury <vbendeb@chromium.org> Gerrit-MessageType: merged
participants (3)
-
Brian Nemec (Code Review) -
Edward O'Callaghan (Code Review)
-
Mary Ruthven (Code Review)