Alan Green has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33832
Change subject: flashchips.c: comma after very .voltage attribute ......................................................................
flashchips.c: comma after very .voltage attribute
To allow automated tools to manipulate flashchips.c, ensure that every voltage attribute ends with a comma, even if it is the last member in the definition.
Signed-off-by: Alan Green avg@google.com Change-Id: Ie609d11ab846361f375f7b024d6ca55f83b01682 --- M flashchips.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/33832/1
diff --git a/flashchips.c b/flashchips.c index 7f3d2a2..e73a4e3 100644 --- a/flashchips.c +++ b/flashchips.c @@ -525,7 +525,7 @@ }, .write = write_jedec_1, .read = read_memmapped, - .voltage = {3000, 3600} /* 3.0-3.6V for type -70R, others 2.7-3.6V */ + .voltage = {3000, 3600}, /* 3.0-3.6V for type -70R, others 2.7-3.6V */ },
{ @@ -557,7 +557,7 @@ }, .write = write_jedec_1, .read = read_memmapped, - .voltage = {3000, 3600} /* 3.0-3.6V for type -70R, others 2.7-3.6V */ + .voltage = {3000, 3600}, /* 3.0-3.6V for type -70R, others 2.7-3.6V */ },
{
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/33832
to look at the new patch set (#2).
Change subject: flashchips.c: comma after every .voltage attribute ......................................................................
flashchips.c: comma after every .voltage attribute
To allow automated tools to manipulate flashchips.c, ensure that every voltage attribute ends with a comma, even if it is the last member in the definition.
Signed-off-by: Alan Green avg@google.com Change-Id: Ie609d11ab846361f375f7b024d6ca55f83b01682 --- M flashchips.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/33832/2
Hello Edward O'Callaghan, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/33832
to look at the new patch set (#5).
Change subject: flashchips.c: Add comma after every .voltage attribute ......................................................................
flashchips.c: Add comma after every .voltage attribute
To allow automated tools to manipulate flashchips.c, ensure that every voltage attribute ends with a comma, even if it is the last member in the definition.
Signed-off-by: Alan Green avg@google.com Change-Id: Ie609d11ab846361f375f7b024d6ca55f83b01682 --- M flashchips.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/33832/5
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33832 )
Change subject: flashchips.c: Add comma after every .voltage attribute ......................................................................
Patch Set 5: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33832 )
Change subject: flashchips.c: Add comma after every .voltage attribute ......................................................................
Patch Set 6: Code-Review+2
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33832 )
Change subject: flashchips.c: Add comma after every .voltage attribute ......................................................................
Patch Set 6: Code-Review+2
Hello HAOUAS Elyes, Edward O'Callaghan, Angel Pons, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/33832
to look at the new patch set (#7).
Change subject: flashchips.c: Add comma after every .voltage attribute ......................................................................
flashchips.c: Add comma after every .voltage attribute
To allow automated tools to manipulate flashchips.c, ensure that every voltage attribute ends with a comma, even if it is the last member in the definition.
Signed-off-by: Alan Green avg@google.com Change-Id: Ie609d11ab846361f375f7b024d6ca55f83b01682 --- M flashchips.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/33832/7
Edward O'Callaghan has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/33832 )
Change subject: flashchips.c: Add comma after every .voltage attribute ......................................................................
flashchips.c: Add comma after every .voltage attribute
To allow automated tools to manipulate flashchips.c, ensure that every voltage attribute ends with a comma, even if it is the last member in the definition.
Signed-off-by: Alan Green avg@google.com Change-Id: Ie609d11ab846361f375f7b024d6ca55f83b01682 Reviewed-on: https://review.coreboot.org/c/flashrom/+/33832 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M flashchips.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
diff --git a/flashchips.c b/flashchips.c index ac65510..ad7ecd7 100644 --- a/flashchips.c +++ b/flashchips.c @@ -525,7 +525,7 @@ }, .write = write_jedec_1, .read = read_memmapped, - .voltage = {3000, 3600} /* 3.0-3.6V for type -70R, others 2.7-3.6V */ + .voltage = {3000, 3600}, /* 3.0-3.6V for type -70R, others 2.7-3.6V */ },
{ @@ -557,7 +557,7 @@ }, .write = write_jedec_1, .read = read_memmapped, - .voltage = {3000, 3600} /* 3.0-3.6V for type -70R, others 2.7-3.6V */ + .voltage = {3000, 3600}, /* 3.0-3.6V for type -70R, others 2.7-3.6V */ },
{
-
Alan Green (Code Review) -
Angel Pons (Code Review)
-
Edward O'Callaghan (Code Review)
-
HAOUAS Elyes (Code Review)