Change in flashrom[master]: tests/linux_spi: Validate param file path
Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62319 ) Change subject: tests/linux_spi: Validate param file path ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File tests/init_shutdown.c: https://review.coreboot.org/c/flashrom/+/62319/comment/83b38283_dab94616 PS4, Line 39: #define DEFAULT_MOCK_FD 0xC0FE
Is there a specific meaning behind this number? We have already a NON_ZERO which is defined as […] NON_ZERO is a negative int... I will fix this in another patch and we should be able to reuse instead of DEFAULT_MOCK_FD. It is currently being used by the wraps for open64 and friends...
-- To view, visit https://review.coreboot.org/c/flashrom/+/62319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If5d24c65f291c53a35509fea5d2f5b3fdb51c306 Gerrit-Change-Number: 62319 Gerrit-PatchSet: 5 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Daniel Campello <campello@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Comment-Date: Wed, 30 Mar 2022 02:29:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Gerrit-MessageType: comment
participants (1)
-
Daniel Campello (Code Review)