[XS] Change in flashrom[main]: Add more delay time for jlink power on feature to stabilize the LDO a...

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: attila-v.

Anastasia Klimchuk has posted comments on this change by attila-v. ( https://review.coreboot.org/c/flashrom/+/86085?usp=email )

Change subject: Add more delay time for jlink power on feature to stabilize the LDO and the decoupling capacitors
......................................................................


Patch Set 2:

(2 comments)

Commit Message:

https://review.coreboot.org/c/flashrom/+/86085/comment/bf8a2ea6_131cc4d1?usp... :
PS2, Line 7: Add more delay time for jlink power on feature to stabilize the LDO and the decoupling capacitors
For this, I can give a suggestion, you can use it or compose a different one (just make sure it wraps at 72 chars)

title (first line)
> jlink_spi: Increase delay on power on feature from 10 to 100 millisec

and then a longer detailed description like this for example
> More delay time is needed to to stabilize the LDO and the decoupling capacitors when power on feature is enabled. Specifically 100 ms was tested on HT7333 and it's sufficient.
> I used the power supply from the J-Link device pin 19.
> this power is 5V, I put a 3.3V LDO (HT7333) after it, and this LDO (and decoupling capacitors) need more time to fix output voltage.

File jlink_spi.c:

https://review.coreboot.org/c/flashrom/+/86085/comment/e3b85a07_5c19de94?usp... :
PS2, Line 469: internal_sleep(100000);
> I think it will be enoughwthis small delay patch for now, nobody will sense this little 0.1 seconds delay which I think is definitely enough.

That's good! Do I understand correctly, you think we can just go ahead with this change? It's easier if parameter is not needed, then all the code you done already.
For me, yes it seems 0.1s is small enough, we can have it.

One thing to do is to update commit message: write a good commit title and message which explains the reason. I did my suggestion (in the other comment) but you can make corrections or add details of you want.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/86085?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ic2dd94e99ac6ffa17a009b8488ce027698ae2c28
Gerrit-Change-Number: 86085
Gerrit-PatchSet: 2
Gerrit-Owner: attila-v
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: attila-v
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: attila-v
Gerrit-Comment-Date: Mon, 12 May 2025 12:06:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <[e-mail]>
Comment-In-Reply-To: attila-v