Change in flashrom[master]: Add initial J-Link SPI programmer
Marc Schink has posted comments on this change. ( https://review.coreboot.org/28087 ) Change subject: Add initial J-Link SPI programmer ...................................................................... Patch Set 5: (2 comments) https://review.coreboot.org/#/c/28087/2/jlink_spi.c File jlink_spi.c: https://review.coreboot.org/#/c/28087/2/jlink_spi.c@344 PS2, Line 344:
Ack, I checked their code... not that they cared to document […] I will add a comment to the documentation, thanks for the pointer ;)
https://review.coreboot.org/#/c/28087/4/jlink_spi.c File jlink_spi.c: https://review.coreboot.org/#/c/28087/4/jlink_spi.c@214 PS4, Line 214: ) {
same here... Necessary since an empty string will be parsed to '0'. Maybe this should be fixed in libjaylink, not sure.
-- To view, visit https://review.coreboot.org/28087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie03a054a75457ec9e1cab36ea124bb53b10e8d7e Gerrit-Change-Number: 28087 Gerrit-PatchSet: 5 Gerrit-Owner: Marc Schink <flashrom-dev@marcschink.de> Gerrit-Reviewer: Marc Schink <flashrom-dev@marcschink.de> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 21 Aug 2018 20:09:37 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
participants (1)
-
Marc Schink (Code Review)