Change in flashrom[master]: Makefile: Fix 'CONFIG_ENABLE_LIBUSB1_PROGRAMMERS=no'

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/39896 )


Change subject: Makefile: Fix 'CONFIG_ENABLE_LIBUSB1_PROGRAMMERS=no'
......................................................................

Makefile: Fix 'CONFIG_ENABLE_LIBUSB1_PROGRAMMERS=no'

Turns out CONFIG_RAIDEN was missing in the LIBUSB1
as no overrides. Credit to HAOUAS Elyes for spotting this.

Change-Id: I7dd26665a0133175949c11717837e9de68a1bf71
Signed-off-by: Edward O'Callaghan <[e-mail]>
---
M Makefile
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/flashrom refs/changes/96/39896/1

diff --git a/Makefile b/Makefile
index 28ceab6..4c6c4cc 100644
--- a/Makefile
+++ b/Makefile
@@ -730,6 +730,7 @@
 override CONFIG_DIGILENT_SPI = no
 override CONFIG_DEVELOPERBOX_SPI = no
 override CONFIG_PICKIT2_SPI = no
+override CONFIG_RAIDEN = no
 override CONFIG_STLINKV3_SPI = no
 endif
 ifeq ($(CONFIG_ENABLE_LIBPCI_PROGRAMMERS), no)

-- 
To view, visit https://review.coreboot.org/c/flashrom/+/39896
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7dd26665a0133175949c11717837e9de68a1bf71
Gerrit-Change-Number: 39896
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-MessageType: newchange

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39896 )

Change subject: Makefile: Fix 'CONFIG_ENABLE_LIBUSB1_PROGRAMMERS=no'
......................................................................


Patch Set 1: Code-Review+2

Fixed 
Thank you


-- 
To view, visit https://review.coreboot.org/c/flashrom/+/39896
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7dd26665a0133175949c11717837e9de68a1bf71
Gerrit-Change-Number: 39896
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: HAOUAS Elyes <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Sat, 28 Mar 2020 10:21:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39896 )

Change subject: Makefile: Fix 'CONFIG_ENABLE_LIBUSB1_PROGRAMMERS=no'
......................................................................


Patch Set 1:

(out of topic)
Do you know why flashrom v1.2-19-g0eee5bb will take longer time than  flashrom v0.9.7-r1711, 
 and it displays so many and many of "Error: SCIP never cleared!" ?

Please see https://pastebin.com/ZHF9vAj3 

Thank you


-- 
To view, visit https://review.coreboot.org/c/flashrom/+/39896
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7dd26665a0133175949c11717837e9de68a1bf71
Gerrit-Change-Number: 39896
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: HAOUAS Elyes <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Sat, 28 Mar 2020 10:45:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39896 )

Change subject: Makefile: Fix 'CONFIG_ENABLE_LIBUSB1_PROGRAMMERS=no'
......................................................................


Patch Set 1:
> Patch Set 1:
>
> (out of topic)
> Do you know why flashrom v1.2-19-g0eee5bb will take longer time than  flashrom v0.9.7-r1711, 
>  and it displays so many and many of "Error: SCIP never cleared!" ?
>
> Please see https://pastebin.com/ZHF9vAj3
>
> Thank you

Does commit 15f539c8c97 relate at all? Not sure what commit g0eee5bb refers to.


-- 
To view, visit https://review.coreboot.org/c/flashrom/+/39896
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7dd26665a0133175949c11717837e9de68a1bf71
Gerrit-Change-Number: 39896
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: HAOUAS Elyes <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Sat, 28 Mar 2020 10:53:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/39896 )

Change subject: Makefile: Fix 'CONFIG_ENABLE_LIBUSB1_PROGRAMMERS=no'
......................................................................

Makefile: Fix 'CONFIG_ENABLE_LIBUSB1_PROGRAMMERS=no'

Turns out CONFIG_RAIDEN was missing in the LIBUSB1
as no overrides. Credit to HAOUAS Elyes for spotting this.

Change-Id: I7dd26665a0133175949c11717837e9de68a1bf71
Signed-off-by: Edward O'Callaghan <[e-mail]>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/39896
Tested-by: build bot (Jenkins) <[e-mail]>
Reviewed-by: HAOUAS Elyes <[e-mail]>
---
M Makefile
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  HAOUAS Elyes: Looks good to me, approved



diff --git a/Makefile b/Makefile
index 28ceab6..4c6c4cc 100644
--- a/Makefile
+++ b/Makefile
@@ -730,6 +730,7 @@
 override CONFIG_DIGILENT_SPI = no
 override CONFIG_DEVELOPERBOX_SPI = no
 override CONFIG_PICKIT2_SPI = no
+override CONFIG_RAIDEN = no
 override CONFIG_STLINKV3_SPI = no
 endif
 ifeq ($(CONFIG_ENABLE_LIBPCI_PROGRAMMERS), no)

-- 
To view, visit https://review.coreboot.org/c/flashrom/+/39896
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7dd26665a0133175949c11717837e9de68a1bf71
Gerrit-Change-Number: 39896
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: HAOUAS Elyes <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-MessageType: merged

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39896 )

Change subject: Makefile: Fix 'CONFIG_ENABLE_LIBUSB1_PROGRAMMERS=no'
......................................................................


Patch Set 2:
> Patch Set 1:
> > Patch Set 1:
> >
> > (out of topic)
> > Do you know why flashrom v1.2-19-g0eee5bb will take longer time than  flashrom v0.9.7-r1711, 
> >  and it displays so many and many of "Error: SCIP never cleared!" ?
> >
> > Please see https://pastebin.com/ZHF9vAj3
> >
> > Thank you
>
> Does commit 15f539c8c97 relate at all? Not sure what commit g0eee5bb refers to.

sorry, it is the latest version.
./flashrom -v
flashrom v1.2-19-gfe6b98b on Linux 5.4.0-4-amd64 (x86_64)
flashrom is free software, get the source code at https://flashrom.org

( commit fe6b98b91ccf )


-- 
To view, visit https://review.coreboot.org/c/flashrom/+/39896
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7dd26665a0133175949c11717837e9de68a1bf71
Gerrit-Change-Number: 39896
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: HAOUAS Elyes <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Sat, 28 Mar 2020 14:40:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39896 )

Change subject: Makefile: Fix 'CONFIG_ENABLE_LIBUSB1_PROGRAMMERS=no'
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit https://review.coreboot.org/c/flashrom/+/39896
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7dd26665a0133175949c11717837e9de68a1bf71
Gerrit-Change-Number: 39896
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: HAOUAS Elyes <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Sat, 28 Mar 2020 15:53:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39896 )

Change subject: Makefile: Fix 'CONFIG_ENABLE_LIBUSB1_PROGRAMMERS=no'
......................................................................


Patch Set 2:
> Patch Set 2:
> > Patch Set 1:
> > > Patch Set 1:
> > >
> > > (out of topic)
> > > Do you know why flashrom v1.2-19-g0eee5bb will take longer time than  flashrom v0.9.7-r1711, 
> > >  and it displays so many and many of "Error: SCIP never cleared!" ?
> > >
> > > Please see https://pastebin.com/ZHF9vAj3
> > >
> > > Thank you
> >
> > Does commit 15f539c8c97 relate at all? Not sure what commit g0eee5bb refers to.
>
> sorry, it is the latest version.
> ./flashrom -v
> flashrom v1.2-19-gfe6b98b on Linux 5.4.0-4-amd64 (x86_64)
> flashrom is free software, get the source code at https://flashrom.org
>
> ( commit fe6b98b91ccf )

here we go (Thx to Angel Pons):
flashrom$ git bisect good
92d6a861ce0e4727c911fd8d6aeba312b805f765 is the first bad commit
commit 92d6a861ce0e4727c911fd8d6aeba312b805f765
Author: Stefan Tauner <[e-mail]>
Date:   Fri Oct 25 00:33:37 2013 +0000

    Refactor Intel Chipset Enables
    
     - Combine enable_flash_ich_4e() and enable_flash_ich_dc() to
       enable_flash_ich_fwh().
     - Remove unjustified (chipset) name parameters from various
       enable_flash_ich* functions.
     - Make Poulsbo and Tunnel Creek use generic enables by refining existing
       functions to work with them, including everything in ichspi.c.
     - Refactor enable_flash_ich_fwh_decode() to be called unconditionally for
       all chipsets.
     - Add support for Intel Atom Centerton (S12x0).
     - Recombine ICH2/3/4/5 to CHIPSET_ICH2345 because we treat them equally
       anyway.
     - Move spibar handling out of ich_init_spi() into enable_flash_ich_spi()
     - Various small cleanups.
    
    Corresponding to flashrom svn r1761.
    
    Signed-off-by: Stefan Tauner <[e-mail]>
    Acked-by: Stefan Tauner <[e-mail]>

 chipset_enable.c | 412 ++++++++++++++++++++++++++-----------------------------
 ichspi.c         |  61 ++------
 programmer.h     |  12 +-
 3 files changed, 214 insertions(+), 271 deletions(-)


-- 
To view, visit https://review.coreboot.org/c/flashrom/+/39896
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7dd26665a0133175949c11717837e9de68a1bf71
Gerrit-Change-Number: 39896
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: HAOUAS Elyes <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Sat, 28 Mar 2020 17:00:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39896 )

Change subject: Makefile: Fix 'CONFIG_ENABLE_LIBUSB1_PROGRAMMERS=no'
......................................................................


Patch Set 2:
> Patch Set 2:
> > Patch Set 2:
> > > Patch Set 1:
> > > > Patch Set 1:
> > > >
> > > > (out of topic)
> > > > Do you know why flashrom v1.2-19-g0eee5bb will take longer time than  flashrom v0.9.7-r1711, 
> > > >  and it displays so many and many of "Error: SCIP never cleared!" ?
> > > >
> > > > Please see https://pastebin.com/ZHF9vAj3
> > > >
> > > > Thank you
> > >
> > > Does commit 15f539c8c97 relate at all? Not sure what commit g0eee5bb refers to.
> >
> > sorry, it is the latest version.
> > ./flashrom -v
> > flashrom v1.2-19-gfe6b98b on Linux 5.4.0-4-amd64 (x86_64)
> > flashrom is free software, get the source code at https://flashrom.org
> >
> > ( commit fe6b98b91ccf )
>
> here we go (Thx to Angel Pons):
> flashrom$ git bisect good
> 92d6a861ce0e4727c911fd8d6aeba312b805f765 is the first bad commit
> commit 92d6a861ce0e4727c911fd8d6aeba312b805f765
> Author: Stefan Tauner <[e-mail]>
> Date:   Fri Oct 25 00:33:37 2013 +0000
>
> Refactor Intel Chipset Enables
>
> - Combine enable_flash_ich_4e() and enable_flash_ich_dc() to
>        enable_flash_ich_fwh().
>      - Remove unjustified (chipset) name parameters from various
>        enable_flash_ich* functions.
>      - Make Poulsbo and Tunnel Creek use generic enables by refining existing
>        functions to work with them, including everything in ichspi.c.
>      - Refactor enable_flash_ich_fwh_decode() to be called unconditionally for
>        all chipsets.
>      - Add support for Intel Atom Centerton (S12x0).
>      - Recombine ICH2/3/4/5 to CHIPSET_ICH2345 because we treat them equally
>        anyway.
>      - Move spibar handling out of ich_init_spi() into enable_flash_ich_spi()
>      - Various small cleanups.
>
> Corresponding to flashrom svn r1761.
>
> Signed-off-by: Stefan Tauner <[e-mail]>
>     Acked-by: Stefan Tauner <[e-mail]>
>
> chipset_enable.c | 412 ++++++++++++++++++++++++++-----------------------------
>  ichspi.c         |  61 ++------
>  programmer.h     |  12 +-
>  3 files changed, 214 insertions(+), 271 deletions(-)

https://paste.flashrom.org/view.php?id=3283
https://paste.flashrom.org/view.php?id=3282


-- 
To view, visit https://review.coreboot.org/c/flashrom/+/39896
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7dd26665a0133175949c11717837e9de68a1bf71
Gerrit-Change-Number: 39896
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: HAOUAS Elyes <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Sat, 28 Mar 2020 17:26:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment