Change in flashrom[master]: add PCI IDs for additional c620 serials PCH chips
Jonathan Zhang has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/44620 ) Change subject: add PCI IDs for additional c620 serials PCH chips ...................................................................... add PCI IDs for additional c620 serials PCH chips Add PCI IDs for C621A, C627A and C629A. Change-Id: I636becd9f08bdf604c6af81ce396049655353b04 Signed-off-by: Jonathan Zhang <jonzhang@fb.com> --- M chipset_enable.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/44620/1 diff --git a/chipset_enable.c b/chipset_enable.c index d56a547..a9e1e0b 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -2034,6 +2034,9 @@ {0x8086, 0xa1c8, B_S, NT, "Intel", "C620 Series Chipset (QS/PRQ)", enable_flash_c620}, {0x8086, 0xa1c9, B_S, NT, "Intel", "C620 Series Chipset (QS/PRQ)", enable_flash_c620}, {0x8086, 0xa1ca, B_S, NT, "Intel", "C629 Series Chipset (QS/PRQ)", enable_flash_c620}, + {0x8086, 0xa1cb, B_S, NT, "Intel", "C621A Series Chipset (QS/PRQ)", enable_flash_c620}, + {0x8086, 0xa1cc, B_S, NT, "Intel", "C627A Series Chipset (QS/PRQ)", enable_flash_c620}, + {0x8086, 0xa1cd, B_S, NT, "Intel", "C629A Series Chipset (QS/PRQ)", enable_flash_c620}, {0x8086, 0xa240, B_S, NT, "Intel", "C620 Series Chipset Supersku", enable_flash_c620}, {0x8086, 0xa241, B_S, NT, "Intel", "C620 Series Chipset Supersku", enable_flash_c620}, {0x8086, 0xa242, B_S, NT, "Intel", "C624 Series Chipset Supersku", enable_flash_c620}, -- To view, visit https://review.coreboot.org/c/flashrom/+/44620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I636becd9f08bdf604c6af81ce396049655353b04 Gerrit-Change-Number: 44620 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jonzhang@fb.com> Gerrit-MessageType: newchange
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44620 ) Change subject: add PCI IDs for additional c620 serials PCH chips ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/44620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I636becd9f08bdf604c6af81ce396049655353b04 Gerrit-Change-Number: 44620 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jonzhang@fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Bryant Ou <bryant.ou.q@gmail.com> Gerrit-Reviewer: David Hendricks <dhendrix.sync@gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 20 Aug 2020 07:22:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44620 ) Change subject: add PCI IDs for additional c620 serials PCH chips ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/flashrom/+/44620/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/flashrom/+/44620/1//COMMIT_MSG@7 PS1, Line 7: serials nit: series -- To view, visit https://review.coreboot.org/c/flashrom/+/44620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I636becd9f08bdf604c6af81ce396049655353b04 Gerrit-Change-Number: 44620 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jonzhang@fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Bryant Ou <bryant.ou.q@gmail.com> Gerrit-Reviewer: David Hendricks <dhendrix.sync@gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 20 Aug 2020 07:22:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44620 ) Change subject: add PCI IDs for additional c620 serials PCH chips ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/flashrom/+/44620/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/flashrom/+/44620/1//COMMIT_MSG@7 PS1, Line 7: serials
nit: series Done
-- To view, visit https://review.coreboot.org/c/flashrom/+/44620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I636becd9f08bdf604c6af81ce396049655353b04 Gerrit-Change-Number: 44620 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jonzhang@fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Bryant Ou <bryant.ou.q@gmail.com> Gerrit-Reviewer: David Hendricks <dhendrix.sync@gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 20 Aug 2020 18:46:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Hello build bot (Jenkins), Maxim Polyakov, Johnny Lin, David Hendricks, Angel Pons, Bryant Ou, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/44620 to look at the new patch set (#2). Change subject: add PCI IDs for additional c620 series PCH chips ...................................................................... add PCI IDs for additional c620 series PCH chips Add PCI IDs for C621A, C627A and C629A. Change-Id: I636becd9f08bdf604c6af81ce396049655353b04 Signed-off-by: Jonathan Zhang <jonzhang@fb.com> --- M chipset_enable.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/44620/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/44620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I636becd9f08bdf604c6af81ce396049655353b04 Gerrit-Change-Number: 44620 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Zhang <jonzhang@fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Bryant Ou <bryant.ou.q@gmail.com> Gerrit-Reviewer: David Hendricks <dhendrix.sync@gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
David Hendricks has submitted this change. ( https://review.coreboot.org/c/flashrom/+/44620 ) Change subject: add PCI IDs for additional c620 series PCH chips ...................................................................... add PCI IDs for additional c620 series PCH chips Add PCI IDs for C621A, C627A and C629A. Change-Id: I636becd9f08bdf604c6af81ce396049655353b04 Signed-off-by: Jonathan Zhang <jonzhang@fb.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/44620 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> --- M chipset_enable.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/chipset_enable.c b/chipset_enable.c index 4772a1c..5fc222b 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -2035,6 +2035,9 @@ {0x8086, 0xa1c8, B_S, NT, "Intel", "C620 Series Chipset (QS/PRQ)", enable_flash_c620}, {0x8086, 0xa1c9, B_S, NT, "Intel", "C620 Series Chipset (QS/PRQ)", enable_flash_c620}, {0x8086, 0xa1ca, B_S, NT, "Intel", "C629 Series Chipset (QS/PRQ)", enable_flash_c620}, + {0x8086, 0xa1cb, B_S, NT, "Intel", "C621A Series Chipset (QS/PRQ)", enable_flash_c620}, + {0x8086, 0xa1cc, B_S, NT, "Intel", "C627A Series Chipset (QS/PRQ)", enable_flash_c620}, + {0x8086, 0xa1cd, B_S, NT, "Intel", "C629A Series Chipset (QS/PRQ)", enable_flash_c620}, {0x8086, 0xa240, B_S, NT, "Intel", "C620 Series Chipset Supersku", enable_flash_c620}, {0x8086, 0xa241, B_S, NT, "Intel", "C620 Series Chipset Supersku", enable_flash_c620}, {0x8086, 0xa242, B_S, NT, "Intel", "C624 Series Chipset Supersku", enable_flash_c620}, -- To view, visit https://review.coreboot.org/c/flashrom/+/44620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I636becd9f08bdf604c6af81ce396049655353b04 Gerrit-Change-Number: 44620 Gerrit-PatchSet: 4 Gerrit-Owner: Jonathan Zhang <jonzhang@fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Bryant Ou <bryant.ou.q@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: David Hendricks <dhendrix.sync@gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: merged
participants (3)
-
Angel Pons (Code Review) -
David Hendricks (Code Review)
-
Jonathan Zhang (Code Review)