Attention is currently required from: Peter Marheine, Richard Hughes, Sergii Dmytruk.

View Change

4 comments:

• File include/libflashrom.h:

  • Patch Set #2, Line 90: * @deprecated Use flashrom_set_progress_callback_v1 instead

    Deprecation is when the thing remains accessible, but I don't see implementation of `flashrom_set_pr […]

    Half of this was forgetting, but other half that I haven't done changes on the live API before. I can see now that was a missing piece, I added the implementation.

    The third half is however, that it is not possible to implement the old method now because callback fn has changed. So my implementation is now just prints an error (but at least, there is an implementation). Would you say it is acceptable?

  • Patch Set #2, Line 101: void* user_data);

    nit: the changes have inconsistent formatting of pointers (space is either before or after an asteri […]

    Done

  • Patch Set #2, Line 113: void flashrom_set_progress_callback_v1(struct flashrom_flashctx *const flashctx,

    Isn't this `v2`? E.g., Linux has `openat()` and `openat2()` syscalls.

    Yes I agree with v2, this makes sense thank you!
    updated everywhere from v1 -> v2

• File include/libflashrom.h:

  • Patch Set #1, Line 93: __attribute__((deprecated("Use flashrom_set_progress_callback_v1 instead")));

    It might make the most sense just to go ahead with deprecated, and adjust if anybody discovers a compiler they want to use that doesn't understand it.

    Yes this makes sense. I followed your advice and left deprecated as it was.

To view, visit change 86031. To unsubscribe, or for help writing mail filters, visit settings.