Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

Patch set 13:Code-Review +1

View Change

1 comment:

• File cli_classic.c:

  • Patch Set #4, Line 635:

    			if (map_flash(&flashes[0]) != 0) {
    				free(flashes[0].chip);
    				ret = 1;
    				goto out_shutdown;
    			}
    			msg_cinfo("Please note that forced reads most likely contain garbage.\n");
    			ret = do_read(&flashes[0], filename);
    			unmap_flash(&flashes[0]);
    

    100% makes sense, I put the easy part out into https://review.coreboot. […]

    Tested with a FT232H adapter:

    Command:
    ```
    sudo ./flashrom -p ft2232_spi:type=232H,divisor=1000 -f -r out -c W25X05
    ```

    Flashrom output:
    ```
    No EEPROM/flash device found.
    Force read (-f -r -c) requested, pretending the chip is there:
    Assuming Winbond flash chip "W25X05" (64 kB, SPI) on ft2232_spi.
    Please note that forced reads most likely contain garbage.
    Block protection could not be disabled!
    Reading flash... done.
    ```

    Data read:
    ```
    xxd out-1khz
    00000000: 0000 07ff ffff e000 0000 7fff fffe 0000 ................
    00000010: 0007 ffff ffe0 0000 007f ffff fe00 0000 ................
    00000020: 07ff ffff e000 0000 7fff fffe 0000 0007 ................
    00000030: ffff ffe0 0000 007f ffff fe00 0000 0fff ................
    ```

    ```
    xxd out-100khz
    00000000: b6db 6db6 db6d b6db 6db6 db6d b6db 6db6 ..m..m..m..m..m.
    00000010: db6d b6db 6db6 db6d b6db 6db6 db6d b6db .m..m..m..m..m..
    00000020: 6db6 db6d b6db 6db6 db24 9249 2492 4924 m..m..m..$.I$.I$
    00000030: 9249 2492 4924 9249 2492 4924 9249 2492 .I$.I$.I$.I$.I$.
    ```

To view, visit change 59291. To unsubscribe, or for help writing mail filters, visit settings.