Attention is currently required from: Nico Huber, Thomas Heijligen, Anastasia Klimchuk, Sergii Dmytruk.

View Change

1 comment:

• File dummyflasher.c:

  • Patch Set #34, Line 169: assert

    I would split it into three functions, but it would complicate CB:59074 where WP starts influencing […]

    I'd rather use assert() than print a warning. If this function gets called with an invalid parameter, then there's a bug in the code. Printing a warning may seem like it could be user error.

To view, visit change 59072. To unsubscribe, or for help writing mail filters, visit settings.