Attention is currently required from: Aarya, Anastasia Klimchuk, Peter Marheine.
View Change
1 comment:
Patchset:
Patch Set #1:
For this patch, it's just the default? Which you also both agree that "safe", or 100%, should be default?
Yes, let's add that option later.
Someone might preferred that "quick" mode, and now boom it would be going away.
What users of flashrom prefer most should always be programming the chip correctly, rather than frying their precious chip "quickly". We should realize that every erase reduces the lifetime of a flash chip, so never toy erase operation, which should be avoided as much as possible.
Never impose a default that fries our precious chip soldered onboard "quickly" to us rational flashrom users, please.
Besides, erase operations remain optimized when all sub-blocks of a block need erase.
To view, visit change 84614. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I9e10749186e395da67ec80e296119f33c3f83122
Gerrit-Change-Number: 84614
Gerrit-PatchSet: 2
Gerrit-Owner: Bill XIE <persmule@hardenedlinux.org>
Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Aarya <aarya.chaumal@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Thu, 10 Oct 2024 14:42:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bill XIE <persmule@hardenedlinux.org>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org>