David Hendricks posted comments on this change.
View Change
Patch set 1:Code-Review +1
(1 comment)
Commit Message:
Patch Set #1, Line 10: There is no reason for it to be a capital letter, is there?
There was a (now obsolete) -u/--upstream function. I don't see a particular reason to change this, but I also don't have a strong opinion here.
To view, visit change 21837. To unsubscribe, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f84d9db2ec3247f313573c5fcd8b9b758ab9d96
Gerrit-Change-Number: 21837
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Tauner <stefan.tauner@gmx.at>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sun, 01 Oct 2017 23:14:07 +0000
Gerrit-HasComments: Yes