View Change
1 comment:
File dummyflasher.c:
Patch Set #4, Line 408: free(data);
Why free `data` here? It has been aliased as `spi_master_dummyflasher.data` already, so we could end up running into use-after-free problems. Plus, all other return paths do not free `data`.
To view, visit change 45230. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I972b085875f1277d9ff33326669d2676a3bcd3aa
Gerrit-Change-Number: 45230
Gerrit-PatchSet: 4
Gerrit-Owner: Lachlan Bishop <lxb@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Namyoon Woo <namyoon@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 10 Sep 2020 07:44:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment