Attention is currently required from: Nico Huber, Peter Marheine.
View Change
1 comment:
File Makefile:
Patch Set #3, Line 332: # Disable the internal programmer on unsupported architectures (everything but x86 and mipsel)
processor_flash_enable() is only called after try_mtd() on line 255, which will skip the rest of the […]
Uff, so on x86 platform which have an mtd driver the original internal programmer is broken when CONFIG_LINUX_MTD is compiled in?
mark_unsupported sets the CONFIG option with an override to no and prevents the build at the end of the config target.
To view, visit change 61300. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad
Gerrit-Change-Number: 61300
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Peter Marheine <pmarheine@chromium.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Mon, 24 Jan 2022 01:42:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org>
Gerrit-MessageType: comment