Attention is currently required from: Nico Huber, Peter Marheine.

View Change

2 comments:

• File Makefile:

  • Patch Set #3, Line 104: CONFIG_INTERNAL_MIPSLE \

    Is this actually true?

    I haven't looked it up yet

  • Patch Set #3, Line 332: # Disable the internal programmer on unsupported architectures (everything but x86 and mipsel)

    Sounds like it compiled with the meson.build by coincidence all the time? […]

    The internal programmer should fail at runtime at internal.c:266 processor_flash_enable() which return 1 on non x86 or specific mips and let the init function return also 1, which indicates an error.

    The whole point of having CONFIG_INTERNAL_<arch> and not only CONFIG_INTERNAL and CONFIG_INTERNAL_X86 is to be able to have multiple implementations of the internal programmer. The CONFIG_INTERNAL is only an alias for the user.

To view, visit change 61300. To unsubscribe, or for help writing mail filters, visit settings.