Attention is currently required from: Nico Huber, David Hendricks, Edward O'Callaghan, Angel Pons, Arthur Heymans.
View Change
1 comment:
Patchset:
Patch Set #1:
Many thanks for spotting this! […]
Yeah I noticed layout.h but I wasn't sure if it was okay to pull that into libflashrom.h (and it wouldn't work as is for the signed case anyway).
Personally I think fixed width makes most sense here, you don't really gain anything from matching it to the machine width. The thing that determines what size this type needs to be (maximum size of available flash chips) doesn't change based on what processor you're running flashrom on. In practice, using long may be slightly less efficient (need REX prefixes on x86_64, takes up twice the size in memory for 64-bit). But I'm happy to implement whatever the majority here wants as long as it gets rid of off_t.
To view, visit change 61943. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I68a386973f79ea634f63dfcd7d95a63400e1fdee
Gerrit-Change-Number: 61943
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: David Hendricks <david.hendricks@gmail.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Comment-Date: Wed, 16 Feb 2022 00:00:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment