Attention is currently required from: Martin L Roth, Thomas Heijligen, Angel Pons, Arthur Heymans, Anastasia Klimchuk.
View Change
1 comment:
Patchset:
Patch Set #1:
Given that "sb600_spi" actually supports more chipsets than just sb600, it makes sense to remove "sb […]
Yes, I was planning on doing a bunch more. This is just the first set of patches.
I wasn't aware of the amd_spi100.c plan when I did this though.
My main complaint is that the file isn't SB600 specific, so that name doesn't make sense to me.
If others have thoughts, I'm glad to help with whatever is desired.
amd_chipsets.c maybe?
To view, visit change 74952. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I13859de27e602cc6496684e6cb66b2dc2e21531a
Gerrit-Change-Number: 74952
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Martin Roth <martin.roth@amd.corp-partner.google.com>
Gerrit-Attention: Martin L Roth <gaumless@gmail.com>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Fri, 19 May 2023 08:19:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment