Attention is currently required from: Patrick Georgi, Martin Roth, Subrata Banik, Caveh Jalali, Stefan Reinauer, Tim Wawrzynczak, Sridhar Siricilla, Angel Pons, Alex Levin, Nick Vaccaro, YH Lin, Boris Mittelberg.
View Change
1 comment:
Patchset:
Patch Set #6:
@Nico, i didn't understand the comment about "cover up the actual problem", the code change in question is not a work around, but a recommendation in the chipset EDS.
The problem description was that multiple processes might use the registers at
once. And as was explained before, the SCIP bit is not meant to be used to
synchronize between multiple processes, and doesn't suffice to do so. Hence,
trying to synchronize via SCIP covers up that there are more severe problems
when using the register interface from mutliple processes at once.
It can, in theory, also cover up problems within flashrom itself, e.g. when
the current checks _after_ the flash cycle are not sufficient.
I fully agree to the EDS recommendation. We should check the bit and if it's
set unexpectedly, bail out. If flashrom itself is responsible for the unexpectedly
set bit, fix that as well.
To view, visit change 61854. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib9265cc20513fd00f32f8fa22e28c312903ca484
Gerrit-Change-Number: 61854
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Alex Levin <levinale@chromium.org>
Gerrit-Reviewer: Boris Mittelberg <bmbm@google.com>
Gerrit-Reviewer: Caveh Jalali <caveh@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <patrick@coreboot.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla@intel.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Patrick Georgi <patrick@coreboot.org>
Gerrit-Attention: Martin Roth <martinroth@google.com>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Caveh Jalali <caveh@chromium.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla@intel.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Alex Levin <levinale@chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Attention: YH Lin <yueherngl@chromium.org>
Gerrit-Attention: Boris Mittelberg <bmbm@google.com>
Gerrit-Comment-Date: Mon, 14 Feb 2022 11:51:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik@google.com>
Gerrit-MessageType: comment