Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
View Change
1 comment:
Commit Message:
Patch Set #10, Line 7: enable write-protection for W25Q{64,128}.V
I thought these are real chips, not only "mock chips used for emulation"? It just so happens that du […]
Yes, these are real chips. I've tested code on a W25Q64 chip, W25Q128V has absolutely identical configuration per datasheets. If code is known to work in general, I'm not sure every individual configuration of bits needs to be tested on hardware before enabling the support (and in case of OTP this is even harder).
To view, visit change 59071. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iccb69a8d3a0dd2192e2c938caddaf07b1889ed35
Gerrit-Change-Number: 59071
Gerrit-PatchSet: 10
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
Gerrit-CC: Nikolai Artemiev <nartemiev@google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Wed, 01 Dec 2021 00:36:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment