Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File tests/init_shutdown.c:

  • Patch Set #1, Line 35:

    #if CONFIG_DUMMY == 1
    void dummy_init_and_shutdown_test_success(void **state)
    {
    	run_lifecycle(state, PROGRAMMER_DUMMY, "bus=parallel+lpc+fwh+spi");
    }
    #endif /* CONFIG_DUMMY */
    

    Actually, this needs more work, I tried as an experiment to use a config option that is not enabled […]

    "yes"/"no" is only used on the user end. Both Meson and the Makefile always use
    `=1` for the `-D` arguments. However, what is rather unfortunate, they only ever
    provide `1` and never `0`. So the only way to use it is useful is indeed with #if.
    :-/

    I think this should change... but that's not a reason to postpone your patch.
    If you want, you can go on with #if.

To view, visit change 55295. To unsubscribe, or for help writing mail filters, visit settings.