Attention is currently required from: Riku Viitanen, Sydney, Thomas Heijligen.

4 comments:

Patchset:
- Patch Set #3:
  Some comments on wording
File doc/supported_hw/supported_prog/serprog/overview.rst:
- Patch Set #2, Line 95: etter performance
  I am not aware of any exiting benchmarks. […]
  I did the performance improvements and I did some very rudimentary benchmarking. It's in this commit message:
  https://github.com/stacksmashing/pico-serprog/commit/ed2520ccb39965deb20d6be11470e65eb4960084
  Total payload throughput gets to about 5 Mbit/s, and I think I'm limited by USB (12 Mbit/s nominal for Full Speed, and USB protocol overhead that I don't fully understand).
  I haven't benchmarked your implementation.
File doc/supported_hw/supported_prog/serprog/overview.rst:
- Patch Set #3, Line 94: over PIO
  "over" can be misunderstood. "instead of" is less ambiguous
- Patch Set #3, Line 95:
```
 pinouts but implements USB descriptors allowing custom udev-rules.
```
  Nothing wrong with what this _says_, but what it _implies_ is a bit confusing. Because these two things are in the same sentence, it seems to imply that arbitrary pinouts are sacrified for gaining custom USB descriptors, but really these are two unrelated features, AFAIUI:
  1. Hardware SPI is used, therefore the pins can't be moved around arbitrarily
  2. Tinyusb used used directly instead of going through the pico-stdio library's USB code. That is what allows having custom (libreboot/pico-serprog) instead of generic (raspberry pi pico) descriptors. The USB device has descriptors in any case.

To view, visit change 82229. To unsubscribe, or for help writing mail filters, visit settings.