Attention is currently required from: Edward O'Callaghan.

View Change

1 comment:

• File flashrom.c:

  • Patch Set #1, Line 41: g_programmer_type

    Since this is a bool, I would name this `g_is_internal_programmer`. `_type` sounds like it stores more than two values. Then a comment about what true and false mean isn't needed as well :)

To view, visit change 70603. To unsubscribe, or for help writing mail filters, visit settings.