Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.
14 comments:
Commit Message:
Patch Set #7, Line 7: tree: provide flashrom context into programmer's delay
It's not passed to the programmers anymore
Done
Add the flashrom context to the delay function declaration, which
located in `struct programmer_entry`.
Doesn't apply anymore. Also, there is not *that* delay function. […]
Done
Patch Set #7, Line 14: TOPIC=register_master_api
Also, if you don't have a huge patch series then a topic doesn't make much sense. […]
That topic was actual as long as this patch changed programmer delay API.
As I see this patch will be a small chain in the series of patches by Edward. He uses `programmer_handle_global` topic in gerrit. I hope he will add `TOPIC=` in his next patches.
Patch Set #7, Line 19: Ticket: https://ticket.coreboot.org/issues/391
Same here. […]
Not directly. That task is blocked and I can't refactor programmer code to use own structure.
I think I should delete it anyway.
File amd_imc.c:
/* flashctx is not completely ready during init, so it's not
* needed (NULL). */
Same here
Done
File atavia.c:
/* flashctx is not needed (NULL) because atavia does
* not use it in its delay function. */
Same here
Done
File dediprog.c:
/* flashctx not needed (NULL) because dediprog does not use it in its
* delay function. */
Same here
Done
File flashrom.c:
Patch Set #1, Line 258: /* return or exit? */
If flashrom continues to execute code, than it will be unexpected behavior. So for now, use exit(). […]
Ack
File flashrom.c:
Patch Set #5, Line 220: void programmer_delay(const struct flashctx *flash, unsigned int usecs)
Currently the commit message doesn't give any hint why this is necessary. […]
Abandoned.
if (!usecs)
return;
if (!programmer->delay)
return internal_delay(flash, usecs); // maybe don't pass context into internal? or pass NULL?
if (!flash) {
msg_perr("%s called but flashctx is not valid!\n"
"Please report a bug at flashrom@flashrom.org\n", __func__);
exit(1);
}
programmer->delay(flash, usecs);
}
leave all this diff out this patch and have it purely just about plumbing flashctx though the contro […]
I got you! Done.
File flashrom.c:
Patch Set #6, Line 226: return internal_delay(flash, usecs);
If we put CB:67393 on top of this patch then `programmer_delay()` has been largely dealt with from t […]
This patch originally did a bit more, so yeah. Thanks for the clarification!
File ichspi.c:
flashctx is not needed (NULL) because ichspi does not use
* it in its delay function. */
Same here
Done
File pony_spi.c:
Also flashctx is not
* completely ready during init anyway.
This doesn't add much value. So please remove.
Done
File raiden_debug_spi.c:
* flashctx not needed (NULL) because raiden_debug_spi does not
* use it in its delay function. Also flashctx is not
* completely ready during init anyway. */
Same here
Done
To view, visit change 66373. To unsubscribe, or for help writing mail filters, visit settings.