Attention is currently required from: Thomas Heijligen.

Patch set 2:Code-Review +1

View Change

4 comments:

• Patchset:

  • Patch Set #2:

    Looks good but would probably be easier to verify as separate commits.

• File Makefile:

  • Patch Set #2, Line 918:

    %.o: %.c config
    	$(CC) -MMD $(CFLAGS) $(CPPFLAGS) $(FLASHROM_CFLAGS) $(FEATURE_CFLAGS) $(SCMDEF) -o $@ -c $<
    
    
    $(PROGRAM)$(EXEC_SUFFIX): $(OBJS)
    	$(CC) -o $(PROGRAM)$(EXEC_SUFFIX) $(OBJS) $(LDFLAGS)
    
    libflashrom.a: $(LIBFLASHROM_OBJS)
    	$(AR) rcs $@ $^
    	$(RANLIB) $@
    
    # TAROPTIONS reduces information leakage from the packager's system.
    # If other tar programs support command line arguments for setting uid/gid of
    # stored files, they can be handled here as well.
    TAROPTIONS = $(shell LC_ALL=C tar --version|grep -q GNU && echo "--owner=root --group=root")
    
    
    # Make sure to add all names of generated binaries here.
    # This includes all frontends and libflashrom.
    # We don't use EXEC_SUFFIX here because we want to clean everything.
    clean:
    	rm -f $(PROGRAM) $(PROGRAM).exe libflashrom.a $(filter-out Makefile.d, $(wildcard *.d *.o)) $(PROGRAM).8 $(PROGRAM).8.html $(BUILD_DETAILS_FILE)
    	@+$(MAKE) -C util/ich_descriptors_tool/ clean
    
    distclean: clean
    	rm -f .libdeps
    
    strip: $(PROGRAM)$(EXEC_SUFFIX)
    	$(STRIP) $(STRIP_ARGS) $(PROGRAM)$(EXEC_SUFFIX)
    

    This looks like it all just moved without changes. Could it be done in a
    separate commit?

  • Patch Set #2, Line 948:

    # to define test programs we use verbatim variables, which get exported
    # to environment variables and are referenced with $$<varname> later
    

    Is this still true?

  • Patch Set #2, Line 953:

    Also, two empty lines should be enough :)

To view, visit change 60107. To unsubscribe, or for help writing mail filters, visit settings.