Evan Benn has uploaded this change for review.

View Change

flashrom_tester: lock_test: Make the logic clear and explicit

Document clearly what the test is doing and expects. Do not use the
push() function as it confuses the logs in the case of error.

BUG=None
BRANCH=None
TEST=None

Change-Id: Ibad559a8ff9696fd91f45bca9d9ceb6e90c41393
---
M util/flashrom_tester/src/tests.rs
1 file changed, 20 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/69400/1

diff --git a/util/flashrom_tester/src/tests.rs b/util/flashrom_tester/src/tests.rs
index 1527a6e..6f2bf1e 100644
--- a/util/flashrom_tester/src/tests.rs
+++ b/util/flashrom_tester/src/tests.rs
@@ -217,12 +217,12 @@
     }
 
     env.wp.set_hw(false)?.set_sw(true)?;
-    // Toggling software WP off should work when hardware is off.
-    // Then enable again for another go.
-    env.wp.push().set_sw(false)?;
+    // Toggling software WP off should work when hardware WP is off.
+    // Then enable software WP again for the next test.
+    env.wp.set_sw(false)?.set_sw(true)?;
 
+    // Toggling software WP off should not work when hardware WP is on.
     env.wp.set_hw(true)?;
-    // Clearing should fail when hardware is enabled
     if env.wp.set_sw(false).is_ok() {
         return Err("Software WP was reset despite hardware WP being enabled".into());
     }

To view, visit change 69400. To unsubscribe, or for help writing mail filters, visit settings.