Attention is currently required from: Thomas Heijligen, Alexander Goncharov.
Patch set 1:Code-Review +1
View Change
2 comments:
File Makefile:
Patch Set #1, Line 1024: @echo "Found \"sphinx-build\" to generate man-pages: $(HAS_SPHINXBUILD)"
The previous lines have the pattern of message
"Checking for XYZ: yes/no"
maybe lets follow the pattern,
Checking for \"sphinx-build\" to generate man-pages: $(HAS_SPHINXBUILD)
?
Patch Set #1, Line 1036: man8/$(PROGRAM).8:
When is this executed? which command runs this?
To view, visit change 74519. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If1b81d9bc25ecac19d493b44b00a7c42d0643fe6
Gerrit-Change-Number: 74519
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Alexander Goncharov <chat@joursoir.net>
Gerrit-Comment-Date: Thu, 20 Apr 2023 11:45:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment