Attention is currently required from: Felix Singer, Idwer Vollering, Angel Pons, Light, Keith Hui.
View Change
1 comment:
Patchset:
Patch Set #10:
I saw it but missed replying. My bad. […]
Thanks so much Keith!
Aarya, you need to add a tag into commit message, above or below Signed-off-by (just add manually):
Tested-by: Keith Hui <buurin@gmail.com>
and remember this for future :)
You may need this again, if someone else tests your patch. Then you ask whether it's ok and add a tag (if yes). Testing is an important part of making changes to the code, it is a good idea to recognise people who helped you with that.
To view, visit change 62761. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7458b416a69fd5e2aa300ca49d1352b6074ad0bc
Gerrit-Change-Number: 62761
Gerrit-PatchSet: 10
Gerrit-Owner: Light <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Keith Hui <buurin@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Idwer Vollering <vidwer@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Idwer Vollering <vidwer@gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Light <aarya.chaumal@gmail.com>
Gerrit-Attention: Keith Hui <buurin@gmail.com>
Gerrit-Comment-Date: Tue, 29 Mar 2022 07:00:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Comment-In-Reply-To: Keith Hui <buurin@gmail.com>
Gerrit-MessageType: comment