Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
Patch set 3:Code-Review +2
View Change
1 comment:
File programmer.c:
Patch Set #3, Line 100: if (data)
While this is consistent with the other patches already merged so maybe worth doing as a cleanup patch after this lands there is no point in this branching.
Either the argument is a non-NULL pointer so we take the branch or the argument is NULL in which case it is a nop.
To view, visit change 54169. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I95bc92f6c54c5bcdac1c522ca87054aaffed0f40
Gerrit-Change-Number: 54169
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Fri, 21 May 2021 00:51:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment