Attention is currently required from: Felix Singer, Nico Huber, Martin Roth, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev.
View Change
2 comments:
File flashrom.8.tmpl:
Patch Set #3, Line 1145: <ec|ap>
What we usually do with programmer arguments is to mention a […]
Done
Patch Set #3, Line 1166: false
Was this tested? I can't find "false" in the code.
It was suggested in review to document like this, it actually works by matching "true" otherwise the default is not-true.
Regarding testing, yes `custom_rst` is sometimes used by bring up engineers.
In any case, resolved.
To view, visit change 62768. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I186920006bdfcc7a9f89542f84b452dfc72b18e4
Gerrit-Change-Number: 62768
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Martin Roth <martinroth@google.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Tue, 12 Apr 2022 00:32:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment