Attention is currently required from: Thomas Heijligen.
Patch set 9:Code-Review +2
View Change
1 comment:
File Makefile.include:
Patch Set #5, Line 40: 2>/dev/null
I've replaced $(shell ...) by $(call debug_shell, ...) to get this upstream. But I'm not a fan of this.
Thank you, I was about to propose this. I also hope it won't stay long.
Once we do everything in a recipe, I guess, we won't have to hide stderr
anymore. Because then the output of any probing command can be
synchronized with our reporting of tested features.
To view, visit change 58623. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I41f5186d9f3e063c12c8c6eea888d0b0bf534259
Gerrit-Change-Number: 58623
Gerrit-PatchSet: 9
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Comment-Date: Tue, 21 Dec 2021 16:16:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Gerrit-MessageType: comment