Attention is currently required from: Charles Parent.

Patch set 1:Code-Review +1

View Change

4 comments:

• Commit Message:

  • Patch Set #1, Line 7: Add FTDI FT4233H

    nit: add the file as prefix:

     ft2232_spi.c: Add FTDI FT4233H

  • Patch Set #1, Line 8:

    Has this change been tested? If so, how? I'd appreciate if you could add this information to the commit message.

  • Patch Set #1, Line 9: Change-Id: I73cee8fd2a6613a8fbc26508d99bbe67da2b4f72

    You'd need to sign-off the commit as per https://flashrom.org/Development_Guidelines#Sign-off_Procedure

• Patchset:

  • Patch Set #1:

    Welcome!

    Looks good, just some comments regarding the commit message. You can update the commit message by amending the commit and repushing: as long as the Change-Id remains the same, Gerrit will treat the new commit as a new patchset (version) of this change. Or you can update the commit message directly using Gerrit's Web UI.

To view, visit change 62480. To unsubscribe, or for help writing mail filters, visit settings.