Attention is currently required from: Anastasia Klimchuk.

Anastasia Klimchuk uploaded patch set #2 to this change.

View Change

The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins)

tests: Check verify op completed in full if chip memory modified

The patch adds new functionality to the test: tracking the areas of
chip memory that were modified (i.e. by erase or write operation),
and then checking those areas were completely covered by verify
operation.

The test operates over the mock chip memory of 16 bytes, so it is
possible to track each byte which was modified, and assert that is
has been verified afterwards.

Adding the test found a bug which is fixed in this commit.
Post-cleanup after processing unaligned region for the case when end
region needs to be extended to align with erase block. Writing was
done correctly, but post-processing of newcontents could go wrong,
which would make verification appear false-negative.

Note: at the moment the test is not fully working, test cases #19
are both failing, for the reason they are very edge cases with
logical layout covering only a part of the chip, and also this
layout being unaligned and smaller than the smallest erase block.
Probably needs some clever hack for testing verification.

[ FAILED ] 2 test(s), listed below:
[ FAILED ] Erase test case #19
[ FAILED ] Write test case #19

Change-Id: I3c5d55a0deb20f23f4072caac8c0dce04cc98fd4
Signed-off-by: Anastasia Klimchuk <aklm@flashrom.org>
---
M erasure_layout.c
M tests/erase_func_algo.c
2 files changed, 119 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/84078/2

To view, visit change 84078. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I3c5d55a0deb20f23f4072caac8c0dce04cc98fd4
Gerrit-Change-Number: 84078
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>