Attention is currently required from: Edward O'Callaghan, Angel Pons.

View Change

4 comments:

• Commit Message:

  • Patch Set #5, Line 9: As observed by Angel Pos, It looks like `pci_filter_init()`

    typo: Pons

  • Patch Set #5, Line 10: initialises the device ID to -1

    What is resulting action from this fact?

• File pcidev.c:

  • Patch Set #5, Line 166: struct pci_dev *pcidev_find_vendorclass(uint16_t vendor, uint16_t devclass)

    The new implementation tests only the first pci device from a vendor on it's class. The old implementation loops through all devices from a vendor.

  • Patch Set #5, Line 168: struct pci_dev *temp = pcidev_find(vendor, -1);

    Please comment here why to use -1 and it's special meaning. When reading the code later its easier to understand it without digging into the git log or libpci implementation. Maybe:
    /* libpci uses -1 as uninitialized filter value. Initializing only the vendor will give us... */

To view, visit change 59281. To unsubscribe, or for help writing mail filters, visit settings.