Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.

Patch set 18:Code-Review +2

View Change

2 comments:

• File hwaccess_io_unittest.h:

  • Patch Set #2:

    There is a flashrom_test_dep in toplevel meson. […]

    So I think we can resolve this for now since there is already merged headers in the top-level that are for tests and can be fixed in a follow up.

    In answer to Nico's question (sorry I missed it too many corp emails while I was out of office) is that with meson the build system is hierarchical where each sub-directory usually has its own meson.build as a unit of work. I guess it is possible to avoid it but I don't think that is canonical or any good reason to do it that way.

    Regarding how to solve the headers being in tests/ - in tests/meson.build the following hunk:

    ```
    flashrom_tests = executable('flashrom_unit_tests',
      srcs,
      include_directories : root_includes,
    ```

    should I guess become:

    ```
    test_includes = include_directories('.')

    flashrom_tests = executable('flashrom_unit_tests',
      srcs,
      include_directories : [root_includes, test_includes],
    ```

    but I think if you just move the headers into tests/ the `-I.` flag is automatically passed and they will be correctly sourced.

• File tests/tests.c:

  • Patch Set #6, Line 88:

    	/*
    	 * Uncomment LOG_ME below for verbose logging.
    	 * It is commented by default because of too many calls.
    	 */
    	/* LOG_ME; */
    

    I haven't done anything with verbosity yet, a general question: is it possible to leave this for the […]

    Ack

To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.