Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Sergii Dmytruk.

View Change

2 comments:

• File spi25_statusreg.c:

  • Patch Set #9, Line 120: msg_cerr("Cannot read register: not supported by chip\n");

    There are multiple ways of writing SR2, so there's a nested if/else chain inside the `if (reg == STA […]

    Thank you! Second paragraph explains it.

• File spi25_statusreg.c:

  • Patch Set #11, Line 124:

    	int ret = spi_send_command(
    			flash, sizeof(read_cmd), sizeof(readarr), &read_cmd, readarr);
    

    Good! One last thing: to have it all on one line, both function call and all arguments. Looks like it fits 112 chars.

To view, visit change 58475. To unsubscribe, or for help writing mail filters, visit settings.