Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Evan Benn.

View Change

10 comments:

• Commit Message:

  • Patch Set #6, Line 10: FFI

    What's this?

  • Patch Set #6, Line 16: and after the change.

    And what's the result of the test?

• File include/libflashrom.h:

  • Patch Set #6, Line 65: file

    a file

    I'm not sure if the examples are needed.

  • Patch Set #6, Line 118:

    /**
     * @brief Returns list of supported flash chips
     * @return List of supported flash chips, or NULL if an error occurred
     */
    struct flashrom_flashchip_info *flashrom_supported_flash_chips(void);
    /**
     * @brief Returns list of supported mainboards
     * @return List of supported mainboards, or NULL if an error occurred
     */
    struct flashrom_board_info *flashrom_supported_boards(void);
    /**
     * @brief Returns list of supported chipsets
     * @return List of supported chipsets, or NULL if an error occurred
     */
    struct flashrom_chipset_info *flashrom_supported_chipsets(void);
    

    Unrelated question, but how does one know the length of the returned list?

  • Patch Set #6, Line 262: short

    small

  • Patch Set #6, Line 356: buffer

    a buffer

  • Patch Set #6, Line 372: another

    I'd use `a` to be more precise, as `flashrom_layout_new()` returns layouts with no regions.

  • Patch Set #6, Line 398:

     * @param start  The start address to be written.
     * @param len    The length of the region to be written.
    

    Maybe @param[out] ?

  • Patch Set #6, Line 416: he

    I'd avoid using personal pronouns in documentation, the caller isn't necessarily a "he". How about:

     The caller must not release the layout as long as it is used through the given flash context.

    Here, "it" refers to "the layout".

  • Patch Set #6, Line 463: [out]

    Why is this an out parameter?

To view, visit change 63903. To unsubscribe, or for help writing mail filters, visit settings.