Attention is currently required from: Daniel Campello.

View Change

7 comments:

• Patchset:

  • Patch Set #6:

    one issue I see is that logging will be sent to stdout for non-errors.

    see flashrom_print_cb in cli_output.c

    can we check for the condition that verbose logging is enabled with sending data to stdout and error? otherwise the user will end up with jarbled-up flash contents on stdout and not know exactly why...

• File cli_classic.c:

  • Patch Set #6, Line 152: (argv[optind][0] != '-' || argv[optind][1] == '\0')

    !strcmp(argv[optind], "-") would be slightly easier to read, IMO

• File flashrom.c:

  • Patch Set #6, Line 1351: strncmp(filename, "-", sizeof("-")))

    strncmp here is analagous to "starts with"

    so this reads: "filename starts with '-'"

    if you wanted filename == '-', then use !strcmp(filename, "-")

  • Patch Set #6, Line 1352: fdopen(STDIN_FILENO, "rb")

    stdin

  • Patch Set #6, Line 1367: (strncmp(filename, "-", sizeof("-"))))

    same comment as above

  • Patch Set #6, Line 1444: trncmp(filename, "-", sizeof("-")))

    ditto, I don't think we want all files that start with - to act this way

  • Patch Set #6, Line 1445: fdopen(STDOUT_FILENO, "wb")

    stdout

To view, visit change 52383. To unsubscribe, or for help writing mail filters, visit settings.