Attention is currently required from: Bill XIE, Peter Marheine.
Patch set 3:Code-Review +2
View Change
1 comment:
Patchset:
Patch Set #3:
This looks good to me, it seems like probe_opcode was just accidentally left out of ich7.
Yes I agree, it looks like probe_opcode should be in both structs, and yes with that they can be merged.
I also did some reading of the git history, nothing there that would contradict.
To view, visit change 84593. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I6a65c97e910622a55da7cef8a10de3af6a99c9e8
Gerrit-Change-Number: 84593
Gerrit-PatchSet: 3
Gerrit-Owner: Bill XIE <persmule@hardenedlinux.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Bill XIE <persmule@hardenedlinux.org>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Sat, 05 Oct 2024 08:55:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nikolai Artemiev <nartemiev@google.com>