Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk.

View Change

2 comments:

• File flash.h:

  • Patch Set #9, Line 203: flashrom_

    I am thinking... do we really need "flashrom" prefix in this struct type name? […]

    This is also exposed through libflashrom.h so I think we should keep the
    "flashrom_" prefix.

  • Patch Set #9, Line 219:

    /* Used for intrepreting configuration bits above */
    	const struct flashchip *chip;
    

    Correction: I found implementation in CB:59183 and further in the chain (and added comments there). […]

    Yeah this was kind of a hack, I've changed it now.

To view, visit change 58478. To unsubscribe, or for help writing mail filters, visit settings.