Attention is currently required from: Aarya, Simon Buhrow, Thomas Heijligen.
View Change
1 comment:
Patchset:
Patch Set #8:
I made it work! […]
I started implementing assertions for expected order of erase blocks invocations, and discovered that each erase block is called twice.
I don't know yet whether it's something in the test, or in the code.
It was not the case in October, but since then both test and code has changed.
I uploaded the latest test that I have, if anyone is interested to have a look!
I don't see anything obvious in the test which would make invoke each eraser twice. Will try to debug later: if there is an issue in the code, it needs to be fixed.
To view, visit change 67535. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8f3fdefb76e71f6f8dc295d9dead5f38642aace7
Gerrit-Change-Number: 67535
Gerrit-PatchSet: 9
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Alexander Goncharov <chat@joursoir.net>
Gerrit-CC: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Aarya <aarya.chaumal@gmail.com>
Gerrit-Comment-Date: Sat, 10 Jun 2023 12:11:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment