Will run manibuilder and hopefully merge later today...
Patch set 5:Code-Review +2
View Change
1 comment:
File physmap.c:
Patch Set #1, Line 433: #if CONFIG_INTERNAL == 1
The prototype for setup_cpu_msr and cleanup_cpu_msr in programmer. […]
I would have preferred to remove the spurious guards in the header
file instead of adding even more guards to the existing mess ;)
I'll try that in a follow-up when testing later.
To view, visit change 35808. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id9e07332003832465a0eccf1d89e73d15abb35c0
Gerrit-Change-Number: 35808
Gerrit-PatchSet: 5
Gerrit-Owner: Jonathan Liu <net147@gmail.com>
Gerrit-Reviewer: Jonathan Liu <net147@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Tue, 08 Oct 2019 09:56:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jonathan Liu <net147@gmail.com>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment