Attention is currently required from: Anastasia Klimchuk.
3 comments:
File tests/init_shutdown.c:
Patch Set #4, Line 41: default_io_mock_state
I would like to rename this, I have two reasons in mind. […]
The two implementations should be homogenised however there is too much code duplication in tests/ so it is unclear where to put the canonical implementation.
It was named 'default' as it provides a default implementation two a otherwise step-stage construction of the state machine behind open(). I am not sure multipath is a good name as that has a very specific meaning already in Linux, unrelated to this, open() is not a singleton function and should respect the path it was feed which it currently does not hence the need for so many patches to resolve the conflict with adding another call to open() somewhere else in flashrom.
Just wondering, why 2 ?
This could be made as a define, it's just the current max paths supported.
I would keep the naming to indicate this piece of data belongs to linux_spi test, "linux_spi_io_stat […]
I am not so sure about this pattern, it looks very Java'ish with long variable names. C already has scoping rules that make it clear about its life-time on the stack. I would actually rather we didn't have prefixes everywhere in stack-local scoped variables.
To view, visit change 62319. To unsubscribe, or for help writing mail filters, visit settings.