Attention is currently required from: Sam McNally, Nico Huber, Nicola Corna, Jack Rosenthal, Paul Menzel, Stefan Reinauer, David Hendricks, Arthur Heymans, Carl-Daniel Hailfinger.

View Change

1 comment:

• File layout.c:

  • Patch Set #33, Line 127:

    	name = colon ? strndup(arg, colon - arg) : strdup(arg);
    	file = colon ? strdup(colon + 1) : NULL;
    

    imo, would be cleaner as […]

    Personally, when I wrote this, I debated between the two options and I think that the current form is better fit to convey that both `name` and `file` are initialized after that point.

To view, visit change 23021. To unsubscribe, or for help writing mail filters, visit settings.