Attention is currently required from: Bora Guvendik, DZ, Nikolai Artemiev, Stefan Reinauer, Subrata Banik.
2 comments:
Patchset:
Hi, our Macronix product manager will discuss this issue recently.
Hello Daniel! Since I don't have datasheet I can't do the review, but I thought maybe you can? You have experience adding support for new chip models, and you contributed a bunch already. Maybe you can review this patch?
The way you do it, open the datasheet, open the patch, and verify each field in chip definition one by one. If you spot anything wrong or unclear, add a comment. If everything is correct, then you can respond and vote +1 on this patch. +1 from you would mean you reviewed and approve.
Do you think you could do it? That would be a lot of help! Thank you!
> Yes, I have the datasheet and chip. We were able to flash with this patch. […]
Yes I was asking in the other comment earlier, if it's possible to send datasheet to me (e.g. by email) so that I can do the review. I was waiting for a follow up on that.
However, another thing I thought about after I read your comment.
We have a patch, and Bora is the author, so we need someone else who has datasheet, to do a review. Perhaps you or Daniel could do that? I don't know if you have datasheet before your eyes, but I would assume Daniel can have it.
I see your other comments, and maybe you started reviewing already! Thank you for your help.
To view, visit change 82626. To unsubscribe, or for help writing mail filters, visit settings.