View Change
1 comment:
File ich_descriptors.c:
Patch Set #2, Line 943: return CHIPSET_300_SERIES_CANNON_POINT;
> Unfortunately I have not found any documentation related to ICCRIBA. […]
The C621A PCH (used in DeltaLake DVT server) has ICCRIBA as 0x34 and NM as 6. With this code change, flashrom guessed it correctly as CHIPSET_C620_SERIES_LEWISBURG.
If CHIPSET_300_SERIES_CANNON_POINT has 0x34 but NM is never 6, I will use "NM == 6" test to differentiate between CHIPSET_300_SERIES_CANNON_POINT and CHIPSET_C620_SERIES_LEWISBURG..
To view, visit change 44621. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I363aaccfb90e0a127c0f0bb0072e9e85c210b669
Gerrit-Change-Number: 44621
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Bryant Ou <bryant.ou.q@gmail.com>
Gerrit-Reviewer: David Hendricks <dhendrix.sync@gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 21 Aug 2020 21:32:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Jonathan Zhang <jonzhang@fb.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment